comments

src/base/TilesRendererBase.js

@@ -4,9 +4,7 @@ import { PriorityQueue } from '../utilities/PriorityQueue.js';
 import { determineFrustumSet, toggleTiles, skipTraversal, markUsedSetLeaves, traverseSet } from './traverseFunctions.js';
 import { UNLOADED, LOADING, PARSING, LOADED, FAILED } from './constants.js';
 
-// TODO: find out why tiles are left dangling in the hierarchy
 // TODO: Address the issue of too many promises, garbage collection
-// TODO: remove more redundant computation
 // TODO: See if using classes improves performance
 // TODO: See if declaring function inline improves performance
 // TODO: Make sure active state works as expected
@@ -124,6 +122,7 @@ export class TilesRendererBase {
 
 		if ( tile.content ) {
 
+			// Fix old file formats
 			if ( ! ( 'uri' in tile.content ) && 'url' in tile.content ) {
 
 				tile.content.uri = tile.content.url;
@@ -138,7 +137,7 @@ export class TilesRendererBase {
 			}
 
 			// TODO: fix for some cases where tilesets provide the bounding volume
-			// but volumes are not present. See
+			// but volumes are not present.
 			if (
 				tile.content.boundingVolume &&
 				! (
@@ -242,9 +241,6 @@ export class TilesRendererBase {
 
                 		tileSets[ url ] = json;
 
-                		// TODO: schedule an update to avoid doing this too many times
-                		this.update();
-
                 	} );
 
 			pr.catch( e => {
@@ -303,7 +299,7 @@ export class TilesRendererBase {
 			t.__loadingState = UNLOADED;
 			t.__loadIndex ++;
 
-			// TODO: Removing from the queues here is slow
+			// TODO: Removing from the queues here is slow?
 			parseQueue.remove( t );
 			downloadQueue.remove( t );
 
@@ -352,6 +348,7 @@ export class TilesRendererBase {
 			} )
 			.then( buffer => {
 
+				// if it has been unloaded then the tile has been disposed
 				if ( tile.__loadIndex !== loadIndex ) {
 
 					return;
@@ -365,6 +362,7 @@ export class TilesRendererBase {
 
 				return parseQueue.add( buffer, priority, buffer => {
 
+					// if it has been unloaded then the tile has been disposed
 					if ( tile.__loadIndex !== loadIndex ) {
 
 						return Promise.resolve();
@@ -378,6 +376,7 @@ export class TilesRendererBase {
 			} )
 			.then( () => {
 
+				// if it has been unloaded then the tile has been disposed
 				if ( tile.__loadIndex !== loadIndex ) {
 
 					return;

src/base/traverseFunctions.js

@@ -279,6 +279,8 @@ export function skipTraversal( tile, renderer ) {
 			tile.__active = true;
 			stats.active ++;
 
+			// load the child content if we've found that we've been loaded so we can move down to the next tile
+			// layer when the data has loaded.
 			for ( let i = 0, l = children.length; i < l; i ++ ) {
 
 				const c = children[ i ];
@@ -308,6 +310,7 @@ export function skipTraversal( tile, renderer ) {
 
 }
 
+// Final traverse to toggle tile visibility.
 export function toggleTiles( tile, renderer ) {
 
 	const frameCount = renderer.frameCount;
@@ -319,11 +322,14 @@ export function toggleTiles( tile, renderer ) {
 		if ( isUsed ) {
 
 			// enable visibility if active due to shadows
+			// TODO: This seems like it should be the resposibility of the implementing class to mark active
+			// tiles as visible if desired.
 			setActive = tile.__active;
 			setVisible = tile.__active || tile.__visible;
 
 		}
 
+		// If the active or visible state changed then call the functions.
 		if ( ! tile.__contentEmpty && tile.__loadingState === LOADED ) {
 
 			if ( tile.__wasSetActive !== setActive ) {